EROPSPT-397: Return AEDs post-initial retention period for AED search endpoint #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleyipsoftwire
commented
Feb 28, 2025
| addr.postcode | ||
| FROM anonymous_elector_document aed | ||
| JOIN aed_contact_details contact ON aed.aed_contact_details_id = contact.id | ||
| LEFT JOIN address addr on contact.address_id = addr.id |
There was a problem hiding this comment.
The only update to this view is changing the JOIN to the address table a LEFT JOIN, so it includes any AEDs that don't have address info anymore.
| @@ -50,28 +49,3 @@ fun buildAnonymousElectorDocumentSummaryEntity( | |||
| postcode = postcode | |||
| ) | |||
| } | |||
|
|
|||
| fun buildAnonymousElectorDocumentSummaryViewFromAedEntity( | |||
There was a problem hiding this comment.
This wasn't used anywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
To keep the PR small-ish, I'm splitting the changes up into multiple PRs. This one is for returning AEDs that have had their first retention period data removed when searched, i.e., showing it in the "Manage AEDs" page.
There will need to be changes to the UI as well, and further changes to the backend for the page that shows individual applications.
Issue ticket number and link
https://mhclgdigital.atlassian.net/browse/EROPSPT-397
Checklist before requesting a review
Additional notes