Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP1-11111: add register check database objects to ems schema #108

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

SimPaySW
Copy link
Contributor

@SimPaySW SimPaySW commented Nov 19, 2024

Description of changes

As part of merging the Register Checker API and EMS Integration API into a single EMS Integration API the register_checker db schema objects need to be added to the ems_integration_application schema. This changeset has added new db changelog files in eip-ero-ems-integration-api repository that include the register_checker db objects.

JIRA item

https://mhclgdigital.atlassian.net/browse/EIP1-11111

Steps that were followed to verify the migration

  1. Start the docker database container and, on a clean schema, run an update migration of these changes to produce a "merged" ems_integration_application-plus-register_checker schema.
liquibase update --username=**** --password=***** --url=jdbc:mysql://localhost:3306/ems_integration_application --changelog-file=src/main/resources/db/changelog/db.changelog-master.yaml 
  1. With reference to the old register_checker db schema,, generate a diff-changelog of the differences to the new ems_integration_application-plus-register_checker schema. This should show the addition of ems_integration objects.
liquibase diff-changelog --changelog-file=changelog-rc-as-ref-schema-11111.xml  \\n--url="jdbc:mysql://127.0.0.1:13306/register_checker" \\n--username=root \\n--password=rootPassword \\n--reference-url="jdbc:mysql://localhost:3306/ems_integration_application" \\n--reference-username=**** \\n--reference-password=*****
  1. On a clean ems_integration_application schema, run an update migration of the main branch changelogs on the schema to populate it with the old set of objects.
liquibase update --username=root --password=rootPassword --url=jdbc:mysql://localhost:3306/ems_integration_application --changelog-file=src/main/resources/db/changelog/db.changelog-master.yaml 
  1. With reference to the old register_checker db schema,, generate a diff-changelog of the differences to the old ems_integration_application schema. This should show no common objects except an address table.
liquibase diff-changelog --changelog-file=changelog-rc-as-ref-schema-main.xml  \\n--url="jdbc:mysql://127.0.0.1:13306/register_checker" \\n--username=**** \\n--password=***** \\n--reference-url="jdbc:mysql://localhost:3306/ems_integration_application" \\n--reference-username=**** \\n--reference-password=*****
  1. Diff the changelogs generated at step 3 with those generated at step 5. Note that the difference between these files is the dropped tables and indexes for the merged register_checker schema. Files are attached as evidence.
    changelog-rc-as-ref-schema-11111.xml.txt
    changelog-rc-as-ref-schema-main.xml.txt

@SimPaySW SimPaySW requested a review from TomHanmer29 November 19, 2024 12:39
Copy link

@TomHanmer29 TomHanmer29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending tech signoff

@SimPaySW
Copy link
Contributor Author

SimPaySW commented Dec 2, 2024

LGTM pending tech signoff

Thanks @TomHanmer29 NB I discovered a few more schema changes to support the merge of the APIs and have pushed a second commit to this branch. I've added Stephen and Andy as reviewers mainly for their visibility of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants