Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS-4573: fixing all the bugs related after comparing with the older system #17

Merged
merged 5 commits into from
Aug 16, 2024

Conversation

nuwan-samarasinghe
Copy link
Collaborator

Fixing identified issues

<script>
// Nunjucks automatically converts any html to escaped html to prevent cross-site scripting
// This method bellow safely unescapes it so it can be rendered correctly.
document.getElementById('{{item.name}}').innerHTML = unescapeHtml('{{item.value}}');

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML Medium

DOM text
is reinterpreted as HTML without escaping meta-characters.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

                    // Nunjucks automatically converts any html to escaped html to prevent cross-site scripting
                    // This method bellow safely unescapes it so it can be rendered correctly.

@nuwan-samarasinghe nuwan-samarasinghe merged commit ab6d653 into main Aug 16, 2024
6 of 10 checks passed
@nuwan-samarasinghe nuwan-samarasinghe deleted the FS-4573-bug-fix branch August 19, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants