Proto new uncompeted journey #125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertkol
commented
Jan 30, 2025
albertkol
force-pushed
the
proto-new-uncompeted-journey
branch
from
7d6bbd6 to
b3dc86d
Compare
albertkol
force-pushed
the
proto-new-uncompeted-journey
branch
from
b3dc86d to
eacc7fa
Compare
|
There was a problem hiding this comment.
Woow nice change @albertkol I am happy to approve but added a comment may be when it resolved I am happy to merge
Can we have a unit test for this scenario possibly a e2e which covers this change ?
Comment on lines
+662
to
+706
| if (!(state["metadata"] && state["metadata"]["change_requests"])) { | ||
| // No Change Requests - Quick return | ||
|
|
||
| return evaluatedComponent; | ||
| } | ||
|
|
||
| // If there are Change Requests | ||
| const changeRequests = state["metadata"]["change_requests"]; | ||
| const componentName = evaluatedComponent.model.name || ""; | ||
| if (componentName in changeRequests) { | ||
| // Component has Change Request - Add feedback to hint | ||
|
|
||
| if (evaluatedComponent.model.hint === undefined) { | ||
| evaluatedComponent.model.hint = {html: ""}; | ||
| } | ||
|
|
||
| const messages = changeRequests[componentName]; | ||
| if (messages) { | ||
| const hints = messages.map((msg) => `<p>${msg}</p>`).join(""); | ||
| evaluatedComponent.model.hint.html += `<div class="govuk-inset-text change-request-block"><header>Assessor feedback</header>${hints}</div>`; | ||
| } | ||
|
|
||
| return evaluatedComponent; | ||
| } | ||
|
|
||
| // Component has no Change Request | ||
| const pageHasNoComponentWithChangeRequest = this.pageDef.components.find(component => component.name in changeRequests); | ||
| if (pageHasNoComponentWithChangeRequest === undefined) { | ||
| // if no Change Request on page - We got here through a condition | ||
|
|
||
| return evaluatedComponent; | ||
| } | ||
|
|
||
|
|
||
| // Change Request on page - Disable all other components on page | ||
| if (evaluatedComponent.model.classes === undefined) { | ||
| evaluatedComponent.model.classes = ""; | ||
| } | ||
| evaluatedComponent.model.classes += " govuk-input--disabled"; | ||
|
|
||
| if (evaluatedComponent.model.hint === undefined) { | ||
| evaluatedComponent.model.hint = {html: ""}; | ||
| } | ||
| evaluatedComponent.model.hint.html += `<div class="govuk-inset-text change-request-disabled"><header>Cannot edit</header></div>`; | ||
|
|
There was a problem hiding this comment.
@albertkol one quick question about this change
I hope this information box is coming on each page if there is a comment from the assessor ? or is there any specific page that comes if this only happens in summary shall we add this to summary page controller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo'd in the video on the LS channel.
New features we need for the Form Runner: