Skip to content

Conversation

@shraavv
Copy link
Contributor

@shraavv shraavv commented Jun 7, 2025

Description (required)

When the user navigates from Explore -> Map -> Details page, the bottom navigation bar is now visible and fully functional.

Fixes #6316

What changes did you make and why?

Added the NavTabLayout tag to fragment_media_details.xml to include the UI element on the page, and implemented the navigation bar functionality in MediaDetailFragment.kt

Tests performed (required)

Tested ProdDebug on emulator with API level 36.0.

Screenshots (for UI changes only)
screenshot_1749318687

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried this branch.
I unfortunately still see the bottom bar disappearing when going back to the home activity.

Additionally, with this branch the bottom bar is visible on the Media Details activity, which is not really useful and not the case in main branch.

Would you mind fixing both?

Thanks! :-)

@shraavv
Copy link
Contributor Author

shraavv commented Jun 8, 2025

I just tried this branch. I unfortunately still see the bottom bar disappearing when going back to the home activity.

Additionally, with this branch the bottom bar is visible on the Media Details activity, which is not really useful and not the case in main branch.

Would you mind fixing both?

Thanks! :-)

could you please clarify how exactly did you navigate from details page to contributions?

@nicolas-raoul
Copy link
Member

By pressing "Back".

@shraavv shraavv closed this Jun 9, 2025
@shraavv shraavv deleted the 6316_fixed_bottomnavbar_issue branch July 18, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bottom navigation bar disappears when tapping Nearby>Explore>Details

2 participants