Fix: prevent showing NearbyCard when seeing our contributions from Profile screen

[rohit9625]

Description (required)

Fixes #6332

What changes did you make and why?
We shouldn't show NearbyCard when seeing our Contributions from ProfileActivity

• We already have conditions to check if we are on the Profile screen by checking userName != null as we show our username on the Profile screen
  

  apps-android-commons/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragment.kt

  Lines 182 to 185 in 06a613e

  	if (arguments != null && requireArguments().getString(ProfileActivity.KEY_USERNAME) != null) {
  	userName = requireArguments().getString(ProfileActivity.KEY_USERNAME)
  	isUserProfile = true
  	}

  
  The above conditions set values some values if we are on the profile screen which is further used to conditionally show NearbyCardView:
  

  apps-android-commons/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragment.kt

  Line 402 in 06a613e

  if (binding!!.cardViewNearby != null && !isUserProfile) {

• We were passing KEY_USERNAME from ProfileAcitivity so that it won't be null when creating ContributionsFragment
  

  apps-android-commons/app/src/main/java/fr/free/nrw/commons/profile/ProfileActivity.kt

  Lines 108 to 111 in 06a613e

  	contributionsFragment = ContributionsFragment().apply {
  	arguments = Bundle().apply {
  	putString(KEY_USERNAME, userName)
  	}

• However, inside the apply block, we are indirectly accessing & passing the userName property of ContributionsFragment, which is null initially, instead of the ProfileActivity's property which leads to unexpected behaviors.

To fix this we can either:

• Pass the userName property like this: putString(KEY_USERNAME, [email protected])
• Or make the userName property private in ContributionsFragment as it's being used there only

So, I make that property private because it also promotes encapsulation :)

Tests performed (required)

Tested prodDebug on Samsung A14 5G with API level 34.

Screenshots (for UI changes only)

Note that NearbyCardView correctly shows on the main Contributions screen but not on the Profile screen

After_Fix.mp4

[github-actions]

✅ Generated APK variants!

• 🤖 Download betaDebugAPK
• 🤖 Download prodDebugAPK

[rohit9625]

The CI is passing now, it seems like the TranslateWiki issue is resolved @nicolas-raoul

[nicolas-raoul]

Working great, thanks!