Fix location prompt uploaded via mobile 5549 #6328
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kota-Jagadeesh
force-pushed
the
fix-location-prompt-uploaded-via-mobile-5549
branch
from
71ecc11 to
09975aa
Compare
nicolas-raoul
requested changes
Jun 6, 2025
There was a problem hiding this comment.
I am getting this build error, would you mind checking? Thanks!
ExploreMapRootFragment.java:242: error: cannot find symbol
mapFragment.requestLocationPermission();
^
symbol: method requestLocationPermission()
location: variable mapFragment of type ExploreMapFragment
|
Yeah will work on it 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5549
I fixed the app so that it doesn’t ask for location permission in the "Uploaded via Mobile" tab. It now only asks for permission in the "Map" tab, as it should. I made changes to
ExploreFragment.javaandExploreMapRootFragment.javato control when the permission is requested, and gave instructions forExploreMapFragment.javato handle the permission request properly.