Skip to content

+ button on pending uploads screen #6327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

Nishthajain7
Copy link

Description (required)

The button allows users to

  • Upload from Camera
  • Upload from Gallery
  • Custom Upload

Fixes #6278

What changes did you make and why?

Refactored PendingUploadsFragment to include the missing + button which enables users to upload Images even when current uploads are pending

Tests performed (required)

Tested ProdDebug build on a real device (Vivo T1x) running API level 30. Verified that:

  • Location permission prompts appear as expected.
  • Camera launches successfully after permission is granted.
  • Permission denial is handled gracefully.

Screenshots (for UI changes only)

image

Need help? See https://support.google.com/android/answer/9075928


Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.

@nicolas-raoul
Copy link
Member

Thanks! I installed your branch on my phone and will test tomorrow. :-)

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :-)

@@ -115,6 +188,81 @@ class PendingUploadsFragment :
}
}

private fun initializeAnimations() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, most of this code is duplicated from ContributionsListFragment.kt?
If yes, how about not duplicating it, for instance by creating an abstract base class?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created a customFabController class in commons/ui and integrated with both ContributionsListFragment.kt and pending uploads screen

@nicolas-raoul
Copy link
Member

From a functional point of view it is working great! :-)

@nicolas-raoul
Copy link
Member

Ah, just another thing to fix: After tapping + and uploading several times, I have to press "Back" many times to reach the "Contributions" screen and see the pictures I uploaded.

translatewiki and others added 12 commits June 8, 2025 22:59
…ce Overlay above other Overlays (commons-app#6334)

Before these changes, when a user tapped on an icon in the Explore Map, the icon and label would often
appear underneath other icons, making it difficult or impossible to read the text on the label.

These changes add two methods that search for and move the icon/label Overlays above all other icons and overlays.
These two methods are called when the user taps on an icon.

Co-authored-by: Nicolas Raoul <[email protected]>
…6341)

* build failure cause

* Fix image selector logic in custom picker
Copy link

github-actions bot commented Jun 9, 2025

✅ Generated APK variants!

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried this branch.
I am still getting this issue:

  1. Upload a picture
  2. You are now in the Pending Uploads activity.
  3. While still in the Pending Uploads activity, tap + to upload a second picture.
  4. You are now in the Pending Uploads activity.
  5. Tap "back".
  6. Problem: you are still in the Pending Uploads activity. You must tap "Back" again to reach the home activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show + button on pending uploads screen too
8 participants