-
Notifications
You must be signed in to change notification settings - Fork 1.3k
+ button on pending uploads screen #6327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks! I installed your branch on my phone and will test tomorrow. :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! :-)
@@ -115,6 +188,81 @@ class PendingUploadsFragment : | |||
} | |||
} | |||
|
|||
private fun initializeAnimations() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly, most of this code is duplicated from ContributionsListFragment.kt?
If yes, how about not duplicating it, for instance by creating an abstract base class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have created a customFabController class in commons/ui and integrated with both ContributionsListFragment.kt and pending uploads screen
From a functional point of view it is working great! :-) |
Ah, just another thing to fix: After tapping + and uploading several times, I have to press "Back" many times to reach the "Contributions" screen and see the pictures I uploaded. |
…ce Overlay above other Overlays (commons-app#6334) Before these changes, when a user tapped on an icon in the Explore Map, the icon and label would often appear underneath other icons, making it difficult or impossible to read the text on the label. These changes add two methods that search for and move the icon/label Overlays above all other icons and overlays. These two methods are called when the user taps on an icon. Co-authored-by: Nicolas Raoul <[email protected]>
…6341) * build failure cause * Fix image selector logic in custom picker
✅ Generated APK variants! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried this branch.
I am still getting this issue:
- Upload a picture
- You are now in the Pending Uploads activity.
- While still in the Pending Uploads activity, tap + to upload a second picture.
- You are now in the Pending Uploads activity.
- Tap "back".
- Problem: you are still in the Pending Uploads activity. You must tap "Back" again to reach the home activity.
Description (required)
The button allows users to
Fixes #6278
What changes did you make and why?
Refactored PendingUploadsFragment to include the missing + button which enables users to upload Images even when current uploads are pending
Tests performed (required)
Tested ProdDebug build on a real device (Vivo T1x) running API level 30. Verified that:
Screenshots (for UI changes only)
Need help? See https://support.google.com/android/answer/9075928
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.