fix: the description language set to bug by default when uploading image in nearby #6221
Conversation
| @@ -15,7 +16,7 @@ class ResultTuple { | |||
| } | |||
|
|
|||
| constructor() { | |||
| language = "bug" // Basa Ugi language - TODO Respect the `Default description language` setting. | |||
| language = Locale.getDefault().language | |||
There was a problem hiding this comment.
Please use the language configured in Settings>Default description language
Thank you!
There was a problem hiding this comment.
so i am trying to use context to access the sharedpreference and get the "descriptionDefaultLanguagePref" key but i am not able get the context. i tried getting the context in NearbyResultItem class through dependency injection but it was coming null, can you help me with this.
There was a problem hiding this comment.
Performing the git bisect described in #6191 (comment) would be the best way to fix the issue. Could you please try?
There was a problem hiding this comment.
@yuvraj-coder1 Did you get time to try this? Do you prefer to let someone else work on it? Thanks!
There was a problem hiding this comment.
yes i fixed it.
sorry for such a late response.
video -link
https://drive.google.com/file/d/1AnqSqyStOOabibVcbxqWwINoB7P3lfGB/view?usp=sharing
i tried doing it with git bisect but was facing some issues in that because when i was going to older commits, the project was getting build errors, so i did it without that. i saw that if the language parameter is empty the logic to pick the language code set in settings was already written.
|
✅ Generated APK variants! |
|
Hi! @nicolas-raoul |
|
@sonalyadav1 Would you mind starting with another issue? Thanks! 🙂 |
Description (required)
Fixes #6191
Removed the hardcoded "bug" string set as the default language when uploading an image in the Nearby feature. Now, the app correctly selects the user's default language instead.
Tests performed (required)
Tested ProdDebug on vivo2334 with API level 35.
Screenshots (for UI changes only)
WhatsApp.Video.2025-02-26.at.15.14.32_b30fbbcf.mp4