-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve environmental variable caching #2101
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2101 +/- ##
==========================================
- Coverage 84.74% 84.57% -0.17%
==========================================
Files 46 46
Lines 8364 8377 +13
Branches 1961 1965 +4
==========================================
- Hits 7088 7085 -3
- Misses 807 818 +11
- Partials 469 474 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @stxue1 ; this will need some extra tests added to confirm your fixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the extra tests! I see that they motivated some code changes :-)
Example: `tox -e py311-unit -- --lf --pdb`
Especially with regards to overrides and `--preserve{-entire,}-environement` Added more tests for environment variable caching Co-authored-by: Michael R. Crusoe <[email protected]>
PR to support environmental variable caching as mentioned here: DataBiosphere/toil#5187 (comment)
The structure of the preserve_environment code is roughly copied from a related function:
cwltool/cwltool/job.py
Lines 486 to 497 in 1b56338