[IMP] pms_api_rest: line notes to invoices in post and section_id field in get#226
Merged
DarioLodeiros merged 2 commits into16.0-mig-pmsfrom Jun 9, 2025
Merged
Conversation
…nes in invoice commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to support the handling of
sectionIdin folio sale lines within the PMS API. The updates include adding a new field to the datamodel, modifying service methods to incorporatesectionId, and implementing logic to process line notes based on their section association.Changes to support
sectionIdin folio sale lines:Datamodel updates:
sectionIdto thePmsFolioSaleInfodatamodel to store section information for folio sale lines. (pms_api_rest/datamodels/pms_folio_sale_line.py, pms_api_rest/datamodels/pms_folio_sale_line.pyR21)Service method updates:
get_folio_sale_linesmethod to includesectionIdwhen constructing folio sale line objects. (pms_api_rest/services/pms_folio_service.py, pms_api_rest/services/pms_folio_service.pyR1400)create_folio_invoicesmethod to process line notes associated with sections. This includes filtering folio sale lines withdisplay_typeset to "line_note" and ensuring their IDs are added to thelines_to_invoice_dict. (pms_api_rest/services/pms_folio_service.py, pms_api_rest/services/pms_folio_service.pyR1532-R1537)