Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event API to have a first view of notable event (Thread create and terminate, Module load and unload) #7

Merged
merged 12 commits into from
May 15, 2022

Conversation

citronneur
Copy link
Collaborator

Hi @commial !

Here a PR that add the event API of TTD on the engine object. This API is very useful to create a firts macro timeline to point directly at an interesting position, like the load of net module.

Have a nice day,

Sylvain

TTD/TTD.hpp Outdated Show resolved Hide resolved
TTD/TTD.hpp Outdated Show resolved Hide resolved
TTD/TTD.hpp Outdated Show resolved Hide resolved
TTD/TTD.hpp Outdated
* \brief More c++ interface using vector
* \return vector of TTD_Replay_ModuleUnloadedEvent
*/
const std::vector<TTD_Replay_ModuleUnloadedEvent> GetModuleUnloadedEvent();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remark for s suffix

TTD/TTD.hpp Outdated
* \brief More c++ interface using vector
* \return vector of TTD_Replay_ThreadCreatedEvent
*/
const std::vector<TTD_Replay_ThreadCreatedEvent> GetThreadCreatedEvent();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remark for s suffix

TTD/TTD.hpp Outdated
* \brief More c++ interface using vector
* \return vector of TTD_Replay_ThreadCreatedEvent
*/
const std::vector<TTD_Replay_ThreadTerminatedEvent> GetThreadTerminatedEvent();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remark for s suffix

example_api/main.cpp Outdated Show resolved Hide resolved
example_api/main.cpp Outdated Show resolved Hide resolved
example_api/main.cpp Outdated Show resolved Hide resolved
example_api/main.cpp Outdated Show resolved Hide resolved
example_api/main.cpp Outdated Show resolved Hide resolved
TTD/TTD.hpp Outdated Show resolved Hide resolved
python-bindings/module.cpp Outdated Show resolved Hide resolved
@commial
Copy link
Owner

commial commented May 13, 2022

Thanks for the PR!

Also, nice catching for the platform context.
Apart from the comment, LGTM

I'm opening #8 to track futures changes

citronneur and others added 9 commits May 15, 2022 10:49
Co-authored-by: Camille Mougey <[email protected]>
Co-authored-by: Camille Mougey <[email protected]>
Co-authored-by: Camille Mougey <[email protected]>
Co-authored-by: Camille Mougey <[email protected]>
Co-authored-by: Camille Mougey <[email protected]>
Co-authored-by: Camille Mougey <[email protected]>
Co-authored-by: Camille Mougey <[email protected]>
Co-authored-by: Camille Mougey <[email protected]>
@commial commial merged commit cb228f8 into commial:master May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants