fix BP_FLAGS::READ value and add some functions #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commial
reviewed
Oct 29, 2022
|
Hi, thanks for the contribution! |
commial
reviewed
Oct 30, 2022
Co-authored-by: Camille Mougey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @commial,
This PR fix BP_FLAGS::READ value in issue #20 and add some functions which have been tested.
When I call some APIs in batches without free the heap pointers from them, the quick memory leak happens...
So, I also add some comments to remind callers to do the extra free job.
Thank again for sharing the cool project.
Best wishes,
YHZX_2013