Skip to content

Fixed issues identified by SonarCloud [#39]#40

Merged
mcpierce merged 1 commit intocomixed:mainfrom
mcpierce:feature/issue-39
Oct 6, 2025
Merged

Fixed issues identified by SonarCloud [#39]#40
mcpierce merged 1 commit intocomixed:mainfrom
mcpierce:feature/issue-39

Conversation

@mcpierce
Copy link
Copy Markdown
Contributor

@mcpierce mcpierce commented Oct 6, 2025

Closes #39

Status

READY

Before You Submit Your PR:

  • Have you announced your PR on the comixed-dev mailing list?
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Refactors existing code (code changes for efficiency or maintainability)
  • Security fix (be sure to include the CVE in the commit message)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mcpierce mcpierce added this to the 3.0 milestone Oct 6, 2025
@mcpierce mcpierce added the enhancement A pull request containing a a new feature, refactoring, or security improvement.. label Oct 6, 2025
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
60.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@mcpierce mcpierce merged commit a55d182 into comixed:main Oct 6, 2025
4 of 5 checks passed
@mcpierce mcpierce deleted the feature/issue-39 branch October 6, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement A pull request containing a a new feature, refactoring, or security improvement..

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix issues identified by SonarCloud.

1 participant