V3 Node Schema Definition (still a massive work in progress) #8656
+10,499
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… out code made during exploration
…es' execute function
…rmeasures to avoid state leaks, ready ability to add extra params to clean class type clone
…other than 'required'/'optional' in the long run
…change formatting (need to change execution.py to recognize it as v3 as well)
…ng to edit execution.py code
…ew convention, make v1 test node have xyz be optional
…mplify defining basic types
…o longer necessary
…ls.hidden will only have values given for corresponding entries in the schema's hidden entry, fixed v3 node check in execution.get_input_data, some cleanup of whitespace and commented out code
…tiType.Input io_types renamed to types
[V3] wancamera, canny, clipsdxl, composite, ..
…ently work, but I will fix that in the next v3 PR
…inputs, fingerprint_inputs, and check_lazy_status, fix Any type for v3 by introducing __ne__ trick from comfy_api's typing.py
[V3] nodes: pag, perpneg, morphology, optimalsteps
[V3] nodes_lt.py and nodes_latent.py
V3 update - removed state
[V3] refactoring of the images save nodes
[V3] SaveVideo, LoadVideo, SaveWEBM, WAN nodes
… to shallow_clone_class not accounting for bases properly
V3 update - fix super() not working within v3's execute classmethod
[v3] converted sag.py, sd3.py, sdupscale.py, slg.py
[V3] Audio-Image Preview refactor
[V3] next 8 converted files
V3 update - remove NumberDisplay.color as it does not exist in the frontend at all currently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a draft pr to help visibility on GitHub and not just have discussion on discord.