Wrap Flux's call with diffusion_model wrappers similar to the Unet model #7382
+16
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I'm currently trying to mod Flux and I found out comfy doesn't have the diffusion model patcher wrapper like the vanilla Unet model does in comfy/ldm/modules/openaimodel.py. The job of this hook is to wrap the diffusion model's call with activatable hooks, which can be numerous.
This makes the modding process, like wrapping the Flux with Reference-only controlnet hooks, very hard without big structural changes.
I think this important, yet small addition of the hook will benefit the extension building community a lot, while not breaking the compatibility.
Additionally, I would like to have the program passing transformer options into the Single Stream and the Double Stream blocks, so the modded information (like reference images) could reach their patched versions without rewriting the whole Flux's forward method. This also will be consistent with how BasicTransformerBlock works in comfy/ldm/modules/attention for vanilla models.