Skip to content

Conversation

silveroxides
Copy link
Contributor

Separate integer primitive that does not contain randomizing function which will act as primary integer primitive and for integers with randomizing, a new primitive named RandInt instead.

This will greatly reduce canvas clutter when using primitive integer for purposes like steps, resolution and other use cases that does not need randomization nor are related to seed.

Having the randomizing element always present also runs the risk of the user accidentally leaving node at random on a primitive that then passes that value to a node that causes server to hang because of it. Possibly even worse.

Separate integer primitive that does not contain randomizing function which will act as primary integer primitive and for integers with randomizing, a new primitive named RandInt instead. 

This will greatly reduce canvas clutter when using primitive integer for purposes like steps, resolution and other use cases that does not need randomization nor are related to seed.

Having the randomizing element always present also runs the risk of the user accidentally leaving node at random on a primitive that then passes that value to a node that causes server to hang because of it. Possibly even worse.
@comfyui-wiki
Copy link
Contributor

Yes, I think this is a good solution. I've had the same issue sometimes. Sometimes, I only want to add an Int node to control steps, but I forget to set it to fixed. As a result, the steps become a large number. I didn't notice this at first. It was only until the workflow had been running for about 20 minutes and still wasn't finished that I realized I set the control_after_generate to random.

@comfyui-wiki
Copy link
Contributor

Just got feedback from a team member. Maybe the better solution is to set the control_after_generate to fixed by default. There is no need to add a extra node.

@silveroxides
Copy link
Contributor Author

That would only adress the issue with accidentally having random primitive integers thrown around. it would not adress the amount of available canvas estate that is occupied by unused widgets which is substantial if you want to set out primitives for let's say steps, width and height. suddenly you just ended up wasting more space by using primitives than using the node it connects to(like the empty latent) and only if you use the width/height in multiple places would it even out. I don't agree at all that a primitive for integers should have an extra widgets for randomizing them as a default simply since the randomizing function only has one single real world use case and that is as Seed randomizing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants