[OPIK-622] Remove deprecated dataset item fields #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mn-named-input-with-non-dictionary-type-values
andrescrz
reviewed
Jan 9, 2025
There was a problem hiding this comment.
For the implementation part, we should keep removing a few more related things that become unused.
Please review the tests carefully. Filtering might still be legitimate on those fields, but as dynamic fields within data. Also, tests related to the migration or the deprecated fields might go away entirely. But please double check that my guidance and assumptions here are correct.
apps/opik-backend/src/main/java/com/comet/opik/api/validate/DatasetItemInputValidator.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/test/java/com/comet/opik/api/resources/v1/priv/DatasetsResourceTest.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/test/java/com/comet/opik/api/resources/v1/priv/DatasetsResourceTest.java
Outdated
Show resolved
Hide resolved
apps/opik-backend/src/test/java/com/comet/opik/api/resources/v1/priv/DatasetsResourceTest.java
Show resolved
Hide resolved
apps/opik-backend/src/test/java/com/comet/opik/api/resources/v1/priv/DatasetsResourceTest.java
Show resolved
Hide resolved
apps/opik-backend/src/test/java/com/comet/opik/api/resources/v1/priv/DatasetsResourceTest.java
Show resolved
Hide resolved
Comment on lines
-4802
to
-4806
| columns.add(Column.builder().name("input").types(Set.of(ColumnType.OBJECT)).filterFieldPrefix("data").build()); | ||
| columns.add(Column.builder().name("expected_output").types(Set.of(ColumnType.OBJECT)).filterFieldPrefix("data") | ||
| .build()); | ||
| columns.add( | ||
| Column.builder().name("metadata").types(Set.of(ColumnType.OBJECT)).filterFieldPrefix("data").build()); |
There was a problem hiding this comment.
Probably the whole addDeprecatedFields doesn't make sense anymore, as we're removing the deprecated fields entirely.
There was a problem hiding this comment.
It's still needed, since we are using it mainly to get expected columns. Renamed for readability.
andrescrz
reviewed
Jan 9, 2025
apps/opik-backend/src/main/java/com/comet/opik/domain/DatasetItemResultMapper.java
Show resolved
Hide resolved
…mn-named-input-with-non-dictionary-type-values
andrescrz
approved these changes
Jan 10, 2025
BorisTkachenko
deleted the
boryst/OPIK-622-dataset-items-include-a-column-named-input-with-non-dictionary-type-values
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Remove deprecated dataset item fields
Testing
Covered by existing integration tests