-
-
Notifications
You must be signed in to change notification settings - Fork 404
Android/cleanup dependency resolution workarounds #5098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android/cleanup dependency resolution workarounds #5098
Conversation
a540764
to
e0b1068
Compare
f98f323
to
cfff4fb
Compare
Hi! I'm I would like to apply some automated changes to this pull request, but it looks like I don't have the necessary permissions to do so. To get this pull request into a mergeable state, please do one of the following two things:
|
eea574d
to
4e1d177
Compare
#5070 should show how to force versions without using |
Retriggered the failing job to see if it's a flake |
@vaslabs happy to merge this if you are done with the PR |
Let me apply @alexarchambault 's suggestion and I'll ping you |
# Conflicts: # build.mill
dc7a0aa
to
02014b2
Compare
@lihaoyi ok this can be merged, there's still work to do to clean dependencies up further, but I'm still experimenting and will do more in follow up PRs |
Summary
Following @alexarchambault work on #4626 I've done some dependency cleanup + others . The aim is to remove as many dependency management workarounds from the past android attempts as possible and rely solely on coursier
Dependency cleanup
I have managed to cleanup most of the examples but I've introduced some small workarounds in two places:
Runtime management
Android resources
I've separated the /resources from /res using
androidResources
and did some housekeeping around classpath resolution.Things left to do
I think I'll need some help from @alexarchambault , I saw this PR #5070, and I'd like some advice on an alternative approach to use endorse strict versions
Test hardening
R8 fixes
On experimenting with 2-compose example, I've found that main dex args are not available for compiling against Api level 21 (so building the compose example with R8 breaks). I removed it for now, it's not a good default, might revisit later on on adding it for older versions of android