Vendor lefou::mill-vcs-version as part of mill-main (backport #4842)
#4850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefou
changed the title
lefou::mill-vcs-version as part of mill-main (#4842)lefou::mill-vcs-version as part of mill-main (backport #4842)
…-lihaoyi#4842) This PR vendors a copy of https://github.com/lefou/mill-vcs-version inside the Mill repo. `mill-vcs-version` is necessary for re-bootstrapping on top of `main`. `mill-mima` or `mill-scalafix` are linters that can be disabled during the re-bootstrapping process and turned on again later when the third-party plugins are available, but `mill-vcs-version` is needing to compute versions during the bootstrapping/dogfooding process and cannot simply be skipped. An alternative would be copy-pasting code into `build.mill` as a temporary hack, but I think it's better to just vendor a full copy of the upstream codebase. `mill-vcs-version` is a pretty small and stable codebase, so the overhead of maintaining a vendored copy should be manageable. Original pull request: com-lihaoyi#4842
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR vendors a copy of https://github.com/lefou/mill-vcs-version
inside the Mill repo.
mill-vcs-versionis necessary for re-bootstrapping on top ofmain.mill-mimaormill-scalafixare linters that can be disabled duringthe re-bootstrapping process and turned on again later when the
third-party plugins are available, but
mill-vcs-versionis needing tocompute versions during the bootstrapping/dogfooding process and cannot
simply be skipped.
An alternative would be copy-pasting code into
build.millas atemporary hack, but I think it's better to just vendor a full copy of
the upstream codebase.
mill-vcs-versionis a pretty small and stablecodebase, so the overhead of maintaining a vendored copy should be
manageable.
Original pull request: #4842