Skip to content

Commit

Permalink
.
Browse files Browse the repository at this point in the history
  • Loading branch information
He-Pin committed Jan 12, 2025
1 parent d882e14 commit 23e03e1
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 17 deletions.
4 changes: 2 additions & 2 deletions build.mill
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ object benchmark extends Cross[BenchmarkModule](build.scalaVersions) with RunMod
println(s"Waiting for server to start..., vt:$vt")
if (!waitForServer(url)) {
serverApp.destroy()
println("Failed to start regular server")
println("Failed to start server")
sys.exit(1)
}

Expand All @@ -144,7 +144,7 @@ object benchmark extends Cross[BenchmarkModule](build.scalaVersions) with RunMod
).call(stderr = os.Pipe)
serverApp.destroy()

println(s"\nResults with $vt:")
println(s"""\nResults with ${if (vt) "(virtual threads)" else "(platform threads)"}:""")
println(results.out.text())
}

Expand Down
8 changes: 3 additions & 5 deletions example/minimalApplicationWithLoom/package.mill
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,12 @@ trait AppModule extends CrossScalaModule{
argsStr.split(" ").filter(_.nonEmpty).toSeq
}

def forkArgs = T {
def forkArgs = Task.Input {
//TODO not sure why the env passing is not working
val envVirtualThread: String = T.env.getOrElse("CASK_VIRTUAL_THREAD", "null")
val envVirtualThread: String = T.env.getOrElse("CASK_VIRTUAL_THREAD", "false")
println("envVirtualThread: " + envVirtualThread)

val systemProps = if (envVirtualThread == "true") {
Seq("-Dcask.virtual-thread.enabled=true")
} else Nil
val systemProps = Seq(s"-Dcask.virtual-thread.enabled=$envVirtualThread")

val baseArgs = Seq(
"--add-opens", "java.base/java.lang=ALL-UNNAMED"
Expand Down
8 changes: 3 additions & 5 deletions example/staticFilesWithLoom/package.mill
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,12 @@ trait AppModule extends CrossScalaModule{ app =>
argsStr.split(" ").filter(_.nonEmpty).toSeq
}

def forkArgs = T {
def forkArgs = Task.Input {
//TODO not sure why the env passing is not working
val envVirtualThread: String = T.env.getOrElse("CASK_VIRTUAL_THREAD", "null")
val envVirtualThread: String = T.env.getOrElse("CASK_VIRTUAL_THREAD", "false")
println("envVirtualThread: " + envVirtualThread)

val systemProps = if (envVirtualThread == "true") {
Seq("-Dcask.virtual-thread.enabled=true")
} else Nil
val systemProps = Seq(s"-Dcask.virtual-thread.enabled=$envVirtualThread")

val baseArgs = Seq(
"--add-opens", "java.base/java.lang=ALL-UNNAMED"
Expand Down
8 changes: 3 additions & 5 deletions example/todoDbWithLoom/package.mill
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,12 @@ trait AppModule extends CrossScalaModule{
argsStr.split(" ").filter(_.nonEmpty).toSeq
}

def forkArgs = T {
def forkArgs = Task.Input {
//TODO not sure why the env passing is not working
val envVirtualThread: String = T.env.getOrElse("CASK_VIRTUAL_THREAD", "null")
val envVirtualThread: String = T.env.getOrElse("CASK_VIRTUAL_THREAD", "false")
println("envVirtualThread: " + envVirtualThread)

val systemProps = if (envVirtualThread == "true") {
Seq("-Dcask.virtual-thread.enabled=true")
} else Nil
val systemProps = Seq(s"-Dcask.virtual-thread.enabled=$envVirtualThread")

val baseArgs = Seq(
"--add-opens", "java.base/java.lang=ALL-UNNAMED"
Expand Down

0 comments on commit 23e03e1

Please sign in to comment.