Skip to content

test: add regression test for go-toml 2.4.x - #415

Merged
zeroshade merged 2 commits into
mainfrom
test/regression-test-for-go-toml
Jul 10, 2026
Merged

test: add regression test for go-toml 2.4.x#415
zeroshade merged 2 commits into
mainfrom
test/regression-test-for-go-toml

Conversation

@amoeba

@amoeba amoeba commented Jul 10, 2026

Copy link
Copy Markdown
Member

go-toml rewrote their serializer in their 2.4.x series and it introduced a
non-consequential serialization difference. We were missing a regression test
that could have caught this so this PR adds that test.

See #406 (comment).

@amoeba

amoeba commented Jul 10, 2026

Copy link
Copy Markdown
Member Author

Fails as expected,

=== RUN   TestMarshalDriverListEmptyTableSection
    driver_list_test.go:150: 
        	Error Trace:	/home/runner/work/dbc/dbc/cmd/dbc/driver_list_test.go:150
        	Error:      	Not equal: 
        	            	expected: "# dbc driver list\n[drivers]\n[drivers.test-driver-1]\n\n[drivers.test-driver-2]\nversion = '>=1.0.0'\n"
        	            	actual  : "# dbc driver list\n[drivers]\n[drivers.test-driver-1]\n[drivers.test-driver-2]\nversion = '>=1.0.0'\n"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -3,3 +3,2 @@
        	            	 [drivers.test-driver-1]
        	            	-
        	            	 [drivers.test-driver-2]
        	Test:       	TestMarshalDriverListEmptyTableSection

See https://github.com/columnar-tech/dbc/actions/runs/29112289291/job/86427264676?pr=415

@amoeba

amoeba commented Jul 10, 2026

Copy link
Copy Markdown
Member Author

CI now passes after I added fccd1bd

@amoeba
amoeba requested a review from zeroshade July 10, 2026 17:52
@zeroshade
zeroshade merged commit bad5d71 into main Jul 10, 2026
16 checks passed
@zeroshade
zeroshade deleted the test/regression-test-for-go-toml branch July 10, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants