refactor: introduce Client type, remove TUI from library, eliminate init() side effects - #361

Merged

zeroshade merged 46 commits into

mainfrom

feat/library-api-refactor

Apr 28, 2026

Commits on Apr 28, 2026

test: add characterization tests for dbc public API
zeroshade
committed
e6eb772
refactor: eliminate init() side effects in dbc package
zeroshade
committed
c2c30b0
refactor: move TUI widgets from dbc and config to cmd/dbc
zeroshade
committed
908903b
feat: add Client type with functional options
zeroshade
committed
5afdc20
feat: implement Client Search, Install, and Uninstall methods
zeroshade
committed
803f87d
feat: implement Client config management methods
zeroshade
committed
3234d0d
feat: add auth options layer to Client
zeroshade
committed
f8b52fe
chore: deprecate old package-level APIs in favor of Client
zeroshade
committed
e42ad95
refactor: update CLI to use Client internally
zeroshade
committed
742ed44
refactor: remove deprecated TUI files from root dbc package
zeroshade
committed
0f84509
fix: address code quality issues from F2 review
zeroshade
committed
3abdeeb
fix: remove remaining deprecated API usages from cmd/dbc
zeroshade
committed
8a378d9
fix: address code review findings from roborev open reviews
zeroshade
committed
30a6150
fix: remove init(), add lazy dbcClient in getDriverRegistry, clean up defer and composite literal
zeroshade
committed
3dc3ae6
fix: extract newDefaultClient helper for DBC_BASE_URL, restore f.Close before RemoveAll
zeroshade
committed
e9ce3f5
fix: remove double-close of tarball file in Install; InflateTarball already closes it
zeroshade
committed
8bccbb1
fix: cleanup tmpdir on downloadPackage error paths, assert credential overwrite in test, add sync.Once to getDriverRegistry lazy init
zeroshade
committed
2e405f4
fix: propagate newDefaultClient error through sync.Once in getDriverRegistry
zeroshade
committed
27d0715
fix: remove sync.Once from getDriverRegistry, use NewRequestWithContext for retry, send fatal errors to stderr
zeroshade
committed
cfda2fb
fix: propagate NewRequestWithContext error in makeRequest, centralize client init with sync.Once in initDBCClient
zeroshade
committed
852e835
fix: store initDBCClient error at package scope so sync.Once failure is visible on subsequent calls
zeroshade
committed
7da2fdd
fix: guard makereq retry against nil resp, use fresh request per call via buildLegacyReq closure
zeroshade
committed
d6bfbf4
fix: deep-copy URL in buildLegacyReq so http.Do mutations don't affect the retry request
zeroshade
committed
d84ea70
fix: document WithUserAgent transport limitation, remove TestClientSearch coupling to TestMain
zeroshade
committed
8e2d0ae
fix: make TestClientSearch fully independent of TestMain by using newInstallTestServer
zeroshade
committed
b7d7721
fix: close response body on non-OK status in DownloadPackage, clone request in uaRoundTripper before mutating headers
zeroshade
committed
0452ec0
fix: explicit body close on non-OK in DownloadPackage, use raw URL string in parse error message
zeroshade
committed
3269f04
feat: add AllVersions, VersionInfo, PackageInfo for external iteration
zeroshade
committed
17fce89
feat: add Client.Download for authenticated tarball streaming
zeroshade
committed
d5c6052
fix: surface response body in Download errors and add unit tests
zeroshade
committed
c875180
fix: guard nil Registry in GetPackage, harden getHTTPClient, rename DocsUrl to DocsURL
zeroshade
committed
e8bacc8
fix: lazy credPath init, mutex for credential slice, check oauth request error, fix temp dir leak and double-close
zeroshade
committed
a0a2629
fix: propagate LicensePath error, hold credMu during load, clean tmpdir on create failure
zeroshade
committed
1853221
fix: close response body on non-200, use HTTPS for wixl packages, sanitize PR title input
zeroshade
committed
d0177c1
fix: return early from ConfigEnv loadConfig, add default subcommand case, close body before non-200 return in fetch
zeroshade
committed
146e5f3
fix: check url.Parse error in GetPackage, eliminate data race in TestCmdStatus
zeroshade
committed
e2d28cd
fix: use NewRequestWithContext in legacy makereq, guard MaxVersion on empty PkgInfo, hint --pre for prerelease versions
zeroshade
committed
2361e7a
fix: check MaxVersion ok in formatDriverInfo for safety
zeroshade
committed
29a76cb
fix: replace panic with os.Exit in GetModelCustom, clarify prerelease filter condition
zeroshade
committed
f6622a5
fix: check Seek error in InflateTarball, rename extra_folder to extraFolder
zeroshade
committed
fa0e2de
fix: use deb.debian.org for wixl packages (ftp.de.debian.org lacks valid HTTPS cert)
zeroshade
committed
79c3ecd
refactor: extract shared helpers, Refresh returns error, MaxVersion returns VersionInfo, deduplicate test boilerplate
zeroshade
committed
b21a7b1
refactor: atomic license write, extract openAndDecodeDriverList, use test helpers, add deprecation tags
zeroshade
committed
150d19a
fix: brace alignment in add.go prerelease check, wrap Refresh error in auth, fix SignedByColumnar deprecation
zeroshade
committed
16fffa4
update comment
zeroshade
committed
588a625
chore: apply workflow security improvements from main (zizmor fixes)

Copilot
and
zeroshade
committed
294956d