chore: don't override Version if set via ldflags - #286
Merged
zeroshade merged 1 commit intoFeb 4, 2026
Conversation
zeroshade
approved these changes
Feb 4, 2026
zeroshade
pushed a commit
that referenced
this pull request
Apr 17, 2026
This fixes a minor issue that prevents us from overriding `Version` with
`ldflags` when we build from a source tarball. Right now, this is only
useful for someone who might want to create a Homebrew formula for dbc
because Homebrew builds from tarballs by default not from git.
This change makes the usual invocation of a build in a Brew formula work
as expected,
```ruby
ldflags = %W[
-s -w
-X github.com/columnar-tech/dbc.Version=v#{version}
]
system "go", "build", *std_go_args(ldflags:), "./cmd/dbc"
```
Without this, dbc built with Homebrew would report,
```sh
$ /opt/homebrew/Cellar/dbc/0.1.0/bin/dbc --version
(devel)
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a minor issue that prevents us from overriding
Versionwithldflagswhen we build from a source tarball. Right now, this is only useful for someone who might want to create a Homebrew formula for dbc because Homebrew builds from tarballs by default not from git.This change makes the usual invocation of a build in a Brew formula work as expected,
Without this, dbc built with Homebrew would report,