fix: panic in search with invalid local manifests - #282
Merged
Conversation
amoeba
changed the title
zeroshade
reviewed
Jan 29, 2026
zeroshade
left a comment
zeroshade
left a comment
Member
There was a problem hiding this comment.
Aside from my nitpick, I would ensure that when we error with this we should make sure to output the path to the manifest that failed. Otherwise, looks good to me
Member
Author
|
That's a good point. I double-checked where we call |
zeroshade
approved these changes
Jan 29, 2026
Member
Author
|
Merging. |
zeroshade
added a commit
that referenced
this pull request
Apr 17, 2026
Fixes a crash a user could encounter if they ran `dbc search` with an invalid driver manifest in a config dir. This can happen because when we run search we also enumerate all of the drivers on the users system so we have to load all the manifests. The fix here makes `decodeManifest` error if name and version aren't set which may also be fixing some latent bugs in other commands. Closes #281 --------- Co-authored-by: Matt Topol <zotthewizard@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a crash a user could encounter if they ran
dbc searchwith an invalid driver manifest in a config dir. This can happen because when we run search we also enumerate all of the drivers on the users system so we have to load all the manifests. The fix here makesdecodeManifesterror if name and version aren't set which may also be fixing some latent bugs in other commands.Closes #281