feat(install): allow install from local package - #265
Conversation
zeroshade
changed the title
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
It installed the package to /home/lidavidm/.config/adbc/drivers/drivername_linux_amd64_v0.1.0.toml which isn't what I'd expect, is it possible to get the 'right' name from the package itself? I guess the info isn't there...
|
Yea, I don't think the info is there, the only option I have is to use the base name of the file. Otherwise we'd need to enforce the name of the package for us to parse it out? I guess I could just check if the filename matches that pattern? |
|
I think it should at least reject the package or maybe ask you to specify a name since the name as-is isn't usable by the driver manager. |
|
Why isn't the name usable by the driver manager? Do we mistake the extension and use the wrong code path? That said, it should be easy enough to add a parameter to specify a name. I'll do that |
|
@lidavidm Can you try and test this again? My updates should address the comments / issues you had. |
|
That does seem to do it |
2 participants
closes #262