fix(install): improve install scripts for unsupported platform - #258
Merged
Conversation
amoeba
reviewed
Jan 20, 2026
amoeba
left a comment
amoeba
left a comment
Member
There was a problem hiding this comment.
Thanks for taking this on for my very niche issue :)
When I try this in an alpine container I get,
/tmp/dbc/scripts # sh install.sh
install.sh: line 1399: HTTP_STATUS: parameter not setI didn't debug but it looks like maybe there's a minor logic issue.
Member
Author
|
We are using the |
amoeba
reviewed
Jan 20, 2026
Member
|
My review comments got doubled up, sorry about the confusion there. My tweaks were,
|
Co-authored-by: Bryce Mecum <petridish@gmail.com>
Co-authored-by: Bryce Mecum <petridish@gmail.com>
Member
Author
|
@amoeba updated from your comments |
zeroshade
added a commit
that referenced
this pull request
Apr 17, 2026
closes #240 --------- Co-authored-by: Bryce Mecum <petridish@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #240