Fix parsing coords that have a minimum range < 0 #619
Merged
+12
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for colorjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
With this fix all tests are green. |
|
Thx! Could we add a changelog entry too? Otherwise this would become a blocker for the upcoming release. |
The acescc color space has coords with a range of [-0.358, 1.468]. The percentageRange function of the Type class was returning a value of [-1, 1] which caused coords specified as percentages to be calculated incorrectly. The percentageRange function will now return [0, 1] if the Type has coordMeta with a range property.
lloydk
force-pushed
the
fix-acescc-test
branch
from
5029ebb to
c83c6ee
Compare
done |
LeaVerou
approved these changes
Dec 26, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The acescc color space has coords with a range of
[-0.358, 1.468].The
percentageRangefunction of theTypeclass was returning a value of[-1, 1]which caused coords specified as percentages to be calculated incorrectly.The
percentageRangefunction will now return[0, 1]if the Type hascoordMetawith arangeproperty.