Fixes bad variable names & property docs; extract code to a function#60
Open
odrais-amsicorp wants to merge 1 commit intocolinmollenhour:masterfrom
Open
Conversation
The `_breakAfter` and `_failAfter` were both commented as being number of seconds. Actually, they are the number of write lock attempts to wait before trying to break the lock and failing the lock-breaking, respectively. So this PR updates the comments appropriately. Also creates a function to return the number of write lock tries per second. Renames _breakAfter and _failAfter properties to _breakAfterLockTries and _failAfterLockBreakTries to clarify what these values are.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
_breakAfterand_failAfterproperties were both commented as being number of seconds. They are used to calculate the number of write lock tries before breaking the lock and failing the lock break, respectively. But when they're actually used, the generated values are marked as being in seconds instead of write lock tries. So this PR updates the comments appropriately.Renames
_breakAfterand_failAfterproperties to_breakAfterLockTriesand_failAfterLockBreakTriesto clarify what these values are.Also creates a function to return the number of write lock tries per second to make the code a bit easier to understand.