Fix deadlock when using session_start(array("read_and_close"=>true))#17
Open
huguesalary wants to merge 1 commit intocolinmollenhour:masterfrom
Open
Fix deadlock when using session_start(array("read_and_close"=>true))#17huguesalary wants to merge 1 commit intocolinmollenhour:masterfrom
session_start(array("read_and_close"=>true))#17huguesalary wants to merge 1 commit intocolinmollenhour:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might not be the best.
The weird thing is that
close()doesn't provide thesession_id()which we need to release the lock.This makes me think this isn't the right place to release the lock, and
read()should probably make sure it releases the lock when it's called with "read_and_close".