Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions batch/github/__tests__/buildPullRequests-filter.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -294,4 +294,15 @@ describe('buildPullRequests filter', () => {
expect(pr2All?.releasedAt).toBe('2024-01-08T00:00:00Z')
expect(pr2Filtered).toEqual(pr2All)
})

test('reviewer が 0 人の PR でも reviewers エントリが生成される', async () => {
// PR#3 は reviewers: [] (basePr デフォルト)
const result = await buildPullRequests(config, prs, mockLoaders)

// reviewer が 0 人でも reviewers 配列に PR のエントリがある
// → batchReplacePullRequestReviewers で古い reviewer レコードが DELETE される
const pr3Reviewers = result.reviewers.find((r) => r.pullRequestNumber === 3)
expect(pr3Reviewers).toBeDefined()
expect(pr3Reviewers?.reviewers).toEqual([])
})
})
25 changes: 13 additions & 12 deletions batch/github/pullrequest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -282,19 +282,20 @@ export const buildPullRequests = async (

// 8. レビュアー(レビュー依頼先)情報を収集
// timeline_items から requestedAt を補完する
// reviewer が 0 人でも push して、removed された reviewer の DB レコードを削除させる
const prReviewers = pr.reviewers ?? []
if (prReviewers.length > 0) {
const timelineItems = await loaders.timelineItems(pr.number)
const requestedAtMap = buildRequestedAtMap(timelineItems)
reviewers.push({
pullRequestNumber: pr.number,
repositoryId: config.repositoryId,
reviewers: prReviewers.map((r) => ({
...r,
requestedAt: requestedAtMap.get(r.login) ?? r.requestedAt,
})),
})
}
const requestedAtMap =
prReviewers.length > 0
? buildRequestedAtMap(await loaders.timelineItems(pr.number))
: new Map<string, string>()
reviewers.push({
pullRequestNumber: pr.number,
repositoryId: config.repositoryId,
reviewers: prReviewers.map((r) => ({
...r,
requestedAt: requestedAtMap.get(r.login) ?? r.requestedAt,
})),
})
} catch (e) {
logger.error(
'analyze failure:',
Expand Down