Fix blocking of Windows Error popups and use in unitTest. #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Let's re-run the two failed Linux checks after #255 has been merged. |
Member
|
@jhmgoossens Do you want to rebase now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing WindowsErrorPopupBlocker() in CoinError.cpp was not actually blocking the Microsoft Visual C++ Runtime Library popups when an assert failed. This is now fixed. Also, the popup blocker is called in CoinUtils unitTest.
Especially during unattended runs, like Github Actions, the popup causes the run to hang until a timeout occurs after 6h for MSVC-based runs in case an assert fails. See an example with Cbc.