[TPC-H] Set split_out=True in groupby-aggregations in Q11, Q13, Q17 and Q18
#1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pre-commit is broken and I think you can update query 11 as well |
hendrikmakait
changed the title
split_out=True in groupby-aggregations in Q17 and Q18split_out=True in groupby-aggregations in Q11, Q17 and Q18
hendrikmakait
changed the title
split_out=True in groupby-aggregations in Q11, Q17 and Q18split_out=True in groupby-aggregations in Q11, Q13, Q17 and Q18
|
It looks like this causes memory pressure for Q18 at scale 10, but I'm inclined to merge anyways. |
phofl
approved these changes
Feb 13, 2024
|
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #1376. In the future, this should be superseded by dask/dask-expr#867.