[CDF-26171] 👷 Infieldv2 yaml #2171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New Files
Modified FilesNo covered modified files...
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2171 +/- ##
==========================================
+ Coverage 84.25% 84.28% +0.02%
==========================================
Files 262 263 +1
Lines 25850 25892 +42
==========================================
+ Hits 21781 21822 +41
- Misses 4069 4070 +1
🚀 New features to boost your workflow:
|
|
|
||
| root_location_external_id: str | None = None | ||
| feature_toggles: FeatureToggles | None = None | ||
| classic_asset_external_id: str | None = None |
Contributor
There was a problem hiding this comment.
Suggested change
| classic_asset_external_id: str | None = None |
not going to be used in v2, can be removed.
| feature_toggles: FeatureToggles | None = None | ||
| classic_asset_external_id: str | None = None | ||
| app_instance_space: str | None = None | ||
| app_data_set: str | None = None |
Contributor
There was a problem hiding this comment.
Suggested change
| app_data_set: str | None = None |
not going to be used in v2, can be removed.
|
|
||
| appInstanceSpace: my_app_instance_space | ||
|
|
||
| appDataSet: my_infield_dataset |
Contributor
There was a problem hiding this comment.
Suggested change
| appDataSet: my_infield_dataset |
not going to be used in v2, can be removed.
| notificationsEndpointExternalId: notifications_endpoint_001 | ||
| attachmentsEndpointExternalId: attachments_endpoint_001 | ||
|
|
||
| classicAssetExternalId: root_asset_external_id_123 |
Contributor
There was a problem hiding this comment.
Suggested change
| classicAssetExternalId: root_asset_external_id_123 |
not going to be used in v2, can be removed.
Comment on lines
36
to
38
| datasetIds: | ||
| - 12345 | ||
| - 67890 |
Contributor
There was a problem hiding this comment.
Suggested change
| datasetIds: | |
| - 12345 | |
| - 67890 |
not going to be used in v2, can be removed.
Comment on lines
49
to
50
| datasetIds: | ||
| - 12345 |
Contributor
There was a problem hiding this comment.
Suggested change
| datasetIds: | |
| - 12345 |
not going to be used in v2, can be removed.
Comment on lines
54
to
56
| datasetIds: | ||
| - 12345 | ||
| - 67890 |
Contributor
There was a problem hiding this comment.
Suggested change
| datasetIds: | |
| - 12345 | |
| - 67890 |
not going to be used in v2, can be removed.
Comment on lines
59
to
60
| datasetIds: | ||
| - 12345 |
Contributor
There was a problem hiding this comment.
Suggested change
| datasetIds: | |
| - 12345 |
not going to be used in v2, can be removed.
Comment on lines
75
to
78
| class ObservationConfig(BaseModelResource): | ||
| external_id: str | ||
| root_location_external_ids: list[str] | None = None | ||
| field_configurations: dict[str, Any] | None = None |
Contributor
There was a problem hiding this comment.
Suggested change
| class ObservationConfig(BaseModelResource): | |
| external_id: str | |
| root_location_external_ids: list[str] | None = None | |
| field_configurations: dict[str, Any] | None = None |
Not in use in V2
Comment on lines
64
to
77
| observationConfig: | ||
| externalId: observation_config_001 | ||
| rootLocationExternalIds: | ||
| - location_001 | ||
| - location_002 | ||
| fieldConfigurations: | ||
| field_1: | ||
| type: text | ||
| label: Description | ||
| required: true | ||
| field_2: | ||
| type: number | ||
| label: Temperature | ||
| unit: celsius |
Contributor
There was a problem hiding this comment.
Suggested change
| observationConfig: | |
| externalId: observation_config_001 | |
| rootLocationExternalIds: | |
| - location_001 | |
| - location_002 | |
| fieldConfigurations: | |
| field_1: | |
| type: text | |
| label: Description | |
| required: true | |
| field_2: | |
| type: number | |
| label: Temperature | |
| unit: celsius |
not going to be used in v2, can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context Cognite Toolkit have
pydanticclasses for all resources we support. This class is used to validate user input and give good error messages if they mistype.This PR add the
InfieldCDMv1YAMLclass that will be used when supporting the new infield configuration format.I built the
InfieldLocationConfigYAMLbased on theInfeildLocationConfigin theInFieldsystem model, and I used the #2159 for all theJSONObjects.Changelog