-
Notifications
You must be signed in to change notification settings - Fork 2
renovate.json: add more package types for lock update #889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
looks like "sbt" doesn't catch them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to add more package types for Renovate's lock file updates. However, the added datasources maven and sbt-package appear to be incorrect for this SBT project. The maven datasource is intended for projects using pom.xml, and sbt-package is not a standard Renovate datasource. This configuration is unlikely to work as intended. My review includes a comment with more details and a suggested correction.
renovate.json
Outdated
| "packageRules": [ | ||
| { | ||
| "matchDatasources": ["sbt"], | ||
| "matchDatasources": ["sbt", "maven", "sbt-package"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The datasources maven and sbt-package appear to be incorrect for this configuration.
- The
mavendatasource is used for Maven projects that have apom.xmlfile. For an SBT project, thesbtdatasource should correctly handle all dependencies, including those fetched from Maven repositories. sbt-packageis not a valid Renovate datasource according to the official documentation. This is likely a typo and will be ignored by Renovate, or it might cause processing errors.
If the sbt datasource is not picking up certain dependencies as expected, could you provide an example of what is being missed? The issue might lie elsewhere in the configuration. Based on the available information, the additions seem incorrect.
| "matchDatasources": ["sbt", "maven", "sbt-package"], | |
| "matchDatasources": ["sbt"], |
|
This pull request seems a bit stale.. Shall we invite more to the party? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #889 +/- ##
=======================================
Coverage 84.73% 84.73%
=======================================
Files 96 96
Lines 2738 2738
Branches 191 191
=======================================
Hits 2320 2320
Misses 418 418 🚀 New features to boost your workflow:
|
looks like "sbt" doesn't catch them