Skip to content

Conversation

@dmivankov
Copy link
Contributor

looks like "sbt" doesn't catch them

looks like "sbt" doesn't catch them
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to add more package types for Renovate's lock file updates. However, the added datasources maven and sbt-package appear to be incorrect for this SBT project. The maven datasource is intended for projects using pom.xml, and sbt-package is not a standard Renovate datasource. This configuration is unlikely to work as intended. My review includes a comment with more details and a suggested correction.

renovate.json Outdated
"packageRules": [
{
"matchDatasources": ["sbt"],
"matchDatasources": ["sbt", "maven", "sbt-package"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The datasources maven and sbt-package appear to be incorrect for this configuration.

  • The maven datasource is used for Maven projects that have a pom.xml file. For an SBT project, the sbt datasource should correctly handle all dependencies, including those fetched from Maven repositories.
  • sbt-package is not a valid Renovate datasource according to the official documentation. This is likely a typo and will be ignored by Renovate, or it might cause processing errors.

If the sbt datasource is not picking up certain dependencies as expected, could you provide an example of what is being missed? The issue might lie elsewhere in the configuration. Based on the available information, the additions seem incorrect.

Suggested change
"matchDatasources": ["sbt", "maven", "sbt-package"],
"matchDatasources": ["sbt"],

@dmivankov dmivankov changed the title renovate.json: add more package tyeps for lock update renovate.json: add more package types for lock update Nov 14, 2025
@github-actions
Copy link

This pull request seems a bit stale.. Shall we invite more to the party?

@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.73%. Comparing base (f1b1cdb) to head (6b853f8).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #889   +/-   ##
=======================================
  Coverage   84.73%   84.73%           
=======================================
  Files          96       96           
  Lines        2738     2738           
  Branches      191      191           
=======================================
  Hits         2320     2320           
  Misses        418      418           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants