Skip to content

Conversation

@thorkildcognite
Copy link
Contributor

This adds support for the primitive timeseries type, that is meant to hold an external-id for a time series existing in the time series resource type.

This adds support for the primitive timeseries type, that is meant
to hold an external-id for a time series existing in the time series
resource type.
@thorkildcognite thorkildcognite requested review from a team and TharinduDG April 2, 2023 22:30
@codecov
Copy link

codecov bot commented Apr 2, 2023

Codecov Report

Merging #604 (a6746b4) into master (1889222) will increase coverage by 0.08%.
The diff coverage is 96.29%.

@@            Coverage Diff             @@
##           master     #604      +/-   ##
==========================================
+ Coverage   79.76%   79.85%   +0.08%     
==========================================
  Files         100      100              
  Lines        3010     3023      +13     
  Branches       41       41              
==========================================
+ Hits         2401     2414      +13     
  Misses        609      609              
Impacted Files Coverage Δ
.../scala/v1/fdm/common/properties/PropertyType.scala 95.65% <95.45%> (+1.05%) ⬆️
...com/cognite/sdk/scala/v1/dataModelProperties.scala 100.00% <100.00%> (ø)
.../v1/fdm/common/properties/PropertyDefinition.scala 86.04% <100.00%> (+0.33%) ⬆️
...dk/scala/v1/fdm/instances/InstanceDefinition.scala 74.07% <100.00%> (+0.38%) ⬆️

Copy link
Contributor

@TharinduDG TharinduDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@thorkildcognite please bump the version and merge :)

@TharinduDG
Copy link
Contributor

taking over with #610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants