-
Notifications
You must be signed in to change notification settings - Fork 35
feat(simulators): Add support for running simulations with routine and model revision external IDs #2267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2267 +/- ##
==========================================
- Coverage 90.85% 90.84% -0.02%
==========================================
Files 167 167
Lines 24843 24857 +14
==========================================
+ Hits 22571 22581 +10
- Misses 2272 2276 +4
🚀 New features to boost your workflow:
|
## [Unreleased] | ||
### Added | ||
- [alpha] Support for running simulations using routine and model revision external IDs. The `SimulationRunWrite` class now supports two modes: running with `routine_external_id` only, or with both `routine_revision_external_id` and `model_revision_external_id`. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## [Unreleased] | |
### Added | |
- [alpha] Support for running simulations using routine and model revision external IDs. The `SimulationRunWrite` class now supports two modes: running with `routine_external_id` only, or with both `routine_revision_external_id` and `model_revision_external_id`. |
we don't write changelog anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in #2339
Closing this PR in favor of that one
Description
This PR extends the Simulator Runs API to support two modes for running simulations:
routine_external_id
routine_revision_external_id
andmodel_revision_external_id
Checklist:
If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.