Skip to content

Fix bug with well-known SIDs #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tw1sm merged 4 commits into from
Dec 16, 2025
Merged

Fix bug with well-known SIDs #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6173029
fix well-known SIDs objectidentifier bug
Tw1sm Dec 12, 2025
d5d5eca
Merge remote-tracking branch 'origin/main' into fix/well-known-sids
Tw1sm Dec 16, 2025
73c2b58
version & changelog
Tw1sm Dec 16, 2025
60f5cc9
Update CHANGELOG.md
Tw1sm Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
# Changelog
## [0.4.20] - 12/16/2025
### Fixes
- Fix [#46](https://github.com/coffeegist/bofhound/issues/46) which caused well-known SIDs (groups) to be mising from bofhound output

## [0.4.19] - 12/12/2025
### Fixes
- Fix [#47](https://github.com/coffeegist/bofhound/issues/47)
Expand Down
6 changes: 2 additions & 4 deletions bofhound/ad/models/bloodhound_group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,9 @@ def __init__(self, object):
logger.debug(f"Reading Group object {ColorScheme.group}{name}[/]", extra=OBJ_EXTRA_FMT)

if 'objectsid' in object.keys():
#objectid = BloodHoundObject.get_sid(object.get('objectsid', None), object.get('distinguishedname', None))
objectid = object.get('objectsid')
self.ObjectIdentifier = objectid
self.Properties["domainsid"] = objectid.rsplit('-',1)[0]

if objectid not in ADUtils.WELLKNOWN_SIDS:
self.Properties["domainsid"] = objectid.rsplit('-',1)[0]

if 'distinguishedname' in object.keys():
self.Properties["distinguishedname"] = object.get('distinguishedname', None).upper()
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "bofhound"
version = "0.4.19"
version = "0.4.20"
description = "Parse output from common sources and transform it into BloodHound-ingestible data"
authors = [
"Adam Brown",
Expand Down