Skip to content

Conversation

@Oaphi
Copy link
Member

@Oaphi Oaphi commented Nov 25, 2025

This PR makes our ability score percent calculation more resilient against incorrect values, specifically against negative thresholds. The new helper method is intended to be expanded in the future to cover other cases (such as setting score thresholds to a value higher than 1.0).

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.49%. Comparing base (1ff2d8b) to head (f839259).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
Components Coverage Δ
controllers 74.55% <ø> (ø)
helpers 84.91% <ø> (ø)
jobs 79.24% <ø> (ø)
models 89.97% <100.00%> (+0.01%) ⬆️
tasks 61.11% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Oaphi Oaphi requested review from ArtOfCode- and cellio November 25, 2025 01:15
Copy link
Member

@cellio cellio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As noted, we're not fixing the frontend here, just the backend, so you can set bad values and we'll handle them without causing server errors.

@Oaphi Oaphi merged commit 28d2763 into develop Nov 26, 2025
13 checks passed
@Oaphi Oaphi deleted the 0valt/resilience branch November 26, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants