Skip unnecessary writes in default impl for modifyGet #70
+105
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
gmega
requested changes
Aug 15, 2024
| @@ -37,6 +37,10 @@ proc defaultModifyGetImpl*( | |||
| except CatchableError as err: | |||
| return failure(err) | |||
|
|
|||
| if maybeCurrentData == maybeNewData: | |||
There was a problem hiding this comment.
🔴 Well technically you should be able to test for this (the absence of a write), and I'd argue you should test for it as otherwise you can't know if your optimization is actually working (which is something we care about, as otherwise there'd be no point in putting it there), no matter how convincing the code looks. 🙂
I'm wiling to let this pass - against my own best judgement - if you tell me that writing such a test is complicated.
There was a problem hiding this comment.
I think that skipping writes is not such a crucial feature that would justify having a test that verify if something was called or not called (one of the worst kinds of tests imo), but I've added such test anyway.
tbekas
force-pushed
the
skip-unnecessary-write
branch
3 times, most recently
from
9bcef1a to
e1046b6
Compare
tbekas
force-pushed
the
skip-unnecessary-write
branch
from
e1046b6 to
c151f93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an optimization only. No functionality is changed, therefore no need to update any tests.