Threaded IO datastore with minimal modifications #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added some tests and a very ugly locking mechanism that we can hopefully refine. The good thing is that all tests pass and there are 0 changes to the api. |
Ok, nice. |
elcritch
reviewed
Sep 18, 2023
|
|
||
| converter toSeq*(self: DataBuffer): seq[byte] = | ||
| ## convert buffer to a seq type using copy and either a byte or char | ||
| ## | ||
|
|
||
| result = newSeq[byte](self.len) | ||
| if self.len() > 0: | ||
| copyMem(addr result[0], unsafeAddr self[].buf[0], self.len) | ||
| copyMem(addr result[0], addr self[].buf[0], self.len) |
There was a problem hiding this comment.
Ah good! I was thinking about that this weekend.
There was a problem hiding this comment.
yeah, but maybe this should also be switched to baseAddr? Not sure.
There was a problem hiding this comment.
Or the other way around, switch baseAddr to addr?
There was a problem hiding this comment.
Imo, addr is probably safer, baseAddr does a straight up cast.
|
This codex-storage/nim-codex#552 works now. |
This was referenced Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.