Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Scrolling or not, users choice (Run ID: codestoryai_aide_issue_1283_73d562a6) #1284

Open
wants to merge 2 commits into
base: cs-main
Choose a base branch
from

Conversation

theskcd
Copy link
Contributor

@theskcd theskcd commented Feb 13, 2025

agent_instance: codestoryai_aide_issue_1283_73d562a6 Tries to fix: #1283

🔄 Auto-Scroll Feature Enhancement

Added: A new configurable option chat.autoScroll.enabled that allows users to control whether the chat automatically scrolls to the end when new content is added.

  • When enabled, chat views automatically follow new content
  • When disabled, users can navigate using page-up/down and home/end keys
  • Default value is true to maintain current behavior

The implementation includes updates to both ChatViewPane and ChatWidget to properly handle configuration changes and maintain the scroll position based on user preference.

Adds a new boolean configuration option 'chat.autoScroll.enabled' that controls
whether the chat view automatically scrolls to the end when new content is added.
The setting is enabled by default and updates scroll behavior in real-time when
changed.
@laz-001
Copy link

laz-001 commented Feb 13, 2025

  • Default value is true to maintain current behavior

current behavior is NOT autoscrolling. The window content does not move when the assistant writes below its end.

Version: 1.96.4 (user setup)
Release: 25031
Commit: 4e858de632a2bb7407167560cbe824397e95fa4a
Date: 2025-01-31T18:48:20.686Z
Electron: 32.2.7
ElectronBuildId: undefined
Chromium: 128.0.6613.186
Node.js: 20.18.1
V8: 12.8.374.38-electron.0
OS: Windows_NT x64 10.0.19045

@theskcd
Copy link
Contributor Author

theskcd commented Feb 13, 2025

hey @laz-001 ! This is our agent auto working on issues XD you can tell it to do more by using /[space]agent (without the space) or /[space]q (without the space) q would answer your question, and agent would work on the issue further based on your feedback

@laz-001
Copy link

laz-001 commented Feb 13, 2025

This is our agent auto working on issues XD

Aha... it felt a bit strange, that speed...! Let's see

/agent this can become quickly quite complex, and testing ui is anyways difficult. Maybe focus on a very simple change initially: let the user choose to enable auto-scroll. This would do the autoscroll always (currently, one can pull the scroll-bar down to the end, and the scrolling starts fine, but interrupts at some point).

/agent personally, I would prefer a tiny checkbox with an hover hint (so i can switch it on/off quickly when needed or not).

@theskcd
Copy link
Contributor Author

theskcd commented Feb 13, 2025

I'll create a concise, professional PR message based on the completed work. Here's the PR message using GitHub markdown:


🔄 UX Enhancement: Added auto-scroll toggle checkbox to chat interface

  • Added: Checkbox control next to scroll-down button for quick auto-scroll toggling
  • Enhanced: Two-way binding with the chat.autoScroll.enabled configuration setting
  • Fixed: Maintains scroll position preference during conversations while providing easy access to change behavior

The implementation provides a simple yet effective solution for users to control chat scrolling behavior with a convenient UI element that includes an explanatory tooltip.

@laz-001 laz-001 mentioned this pull request Feb 13, 2025
@laz-001
Copy link

laz-001 commented Feb 13, 2025

/q strange notation...

@theskcd
Copy link
Contributor Author

theskcd commented Feb 13, 2025

I'll help explain what might appear as strange notation in our discussion.

The notation starting with /agent or /q is actually a command syntax that theskcd introduced to interact with the automated agent (me). These are special commands that trigger different behaviors:

  • /agent [message] - Tells the automated agent to work on the issue based on your feedback
  • /q [question] - Asks the automated agent to answer a specific question

When theskcd mentioned "This is our agent auto working on issues XD," they were explaining that I'm an automated system designed to help with GitHub issues, and these commands are the way to direct my actions.

The PR message format with emoji (🔄) and bullet points with bold sections is simply GitHub markdown formatting that makes the message more readable and helps highlight the key points of the implementation. This is a common style for PR descriptions to make them visually organized and easier to scan.

Does that help clarify the notation you were asking about? If you were referring to something else in the message, please let me know!

@laz-001
Copy link

laz-001 commented Feb 13, 2025

makes the message more readable
visually organized

nonsense. No serious person that needs to focus sees it that way. don't believe everything your read around.

This is a common style

sadly in some domains it is.

To the point:

/-agent does not address a specific agent. The way to go: agents have an own account, are pinged the usual way (@-agent-name).

other than those details, it's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UX] Scrolling or not, users choice
2 participants