[bean] review용 PR#222
Open
tjdqls1200 wants to merge 74 commits intocodesquad-members-2023:review-beanfrom
Open
[bean] review용 PR#222tjdqls1200 wants to merge 74 commits intocodesquad-members-2023:review-beanfrom
tjdqls1200 wants to merge 74 commits intocodesquad-members-2023:review-beanfrom
Conversation
- 게임을 진행하는 LadderGame 클래스 생성 - 게임 입출력을 담당하는 Screen 클래스 생성
[bean] step-1 구현
[bean] step-2 구현
- 중복 이름 제외 - 알파벳 + 숫자 1~5 자리 허용
[bean] step-3 구현
- 시작 위치와 현재 위치를 나타내는 Point 클래스 생성 - 방향을 나타내는 Direction Enum 클래스 생성
- Ladder 생성 성공, 실패 테스트 - 사다리 모양 List<String> 생성 테스트 - 사다리 게임 결과 생성 테스트
- Colleciton을 Optional로 감싸는 코드 제거 - while문에서 Optional isEmpty()를 체크하면서 반복하던 코드를 orElseGet()으로 수정
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.