Revert "Sanne/perf remove unused gql fields" #8800
Merged
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 967ecbb.
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
tristandubbeld
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #8799
There's a type error that I don't understand, so it won't deploy anyway. Making me think maybe we do use these sandboxes? I don't have time to properly look into it.
src/app/pages/Dashboard/Content/routes/Recent/index.tsx(92,30): error TS2339: Property 'sandboxes' does not exist on type 'SidebarState'.<- this is the type error, but I don't understand because when I deployed to stream it did just work and showed me recent sandboxes. Here we're trying to read the sandboxes from the sidebar state, but I'm pretty sure we have them elsewhere ij ust don't know where.(The linting errors were related to unused variables, but those are easily fixed)