Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eliminate usage of disabled buttons #233

Merged

Conversation

HuxleyBerry
Copy link
Member

@HuxleyBerry HuxleyBerry commented Feb 27, 2025

Change Summary

  • I've gone through the code and got rid of making buttons disabled while there are still validation errors
  • Instead, the button remains enabled, but some sort of message appears asking you to fix the errors, and no request to the backend gets sent

Change Form

Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

  • The pull request title has an issue number
  • The change works by "Smoke testing" or quick testing
  • The change has tests
  • The change has documentation

Other Information

[Is there anything in particular in the review that I should be aware of?]

Related issue

@HuxleyBerry HuxleyBerry self-assigned this Feb 27, 2025
Copy link

vercel bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blingo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 7:59am

@HuxleyBerry HuxleyBerry merged commit 77f0cf7 into main Mar 4, 2025
8 checks passed
@HuxleyBerry HuxleyBerry deleted the issue-229-Improve_form_UX_by_removing_disabled_buttons branch March 4, 2025 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve form UX by removing disabled buttons
1 participant