Change insecure links #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 1, 2022 17:50
- one link can be de-duplicated - text becomes easier to read
The README contained a link pointing to the docs of Kubernetes v1.18. The docs for that version are no longer online, and when visiting the link your browser shows a message about an invalid certificate. In this commit, I changed the file to point to a newer version of the docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there 👋
I noticed an issue when clicking the "LabelSelector" link in the README. My browser (Firefox) notified me that the certificate for that site was invalid.
I guess this is because the Kubernetes docs only list v1.19 and later, and the link points to the v1.18 docs?
In any case, I changed the links to point to a more recent version of the docs, but please check if that link is ok.
I also took the liberty of moving all links to the bottom of the page. Then the LabelSelector link can be de-duplicated, and the file is a bit nicer to read.