feat: add --disable-* options

[DanielleMaywood]

This PR adds several new configuration options to the code-server devcontainer feature that allow users to disable specific functionality:

• disableFileDownloads: Prevents users from downloading files from the editor
• disableFileUploads: Prevents users from uploading files to the editor
• disableGettingStartedOverride: Disables the coder/coder override in Help: Getting Started
• disableProxy: Disables domain and path proxy routes
• disableTelemetry: Disables telemetry reporting
• disableUpdateCheck: Disables the update check that runs every 6 hours
• disableWorkspaceTrust: Disables the Workspace Trust feature for the current session

[Copilot]

Copilot reviewed 1 out of 12 changed files in this pull request and generated 1 comment.

Files not reviewed (11)

• src/code-server/devcontainer-feature.json: Language not supported
• src/code-server/install.sh: Language not supported
• test/code-server/code-server-disable-file-downloads.sh: Language not supported
• test/code-server/code-server-disable-file-uploads.sh: Language not supported
• test/code-server/code-server-disable-getting-started-override.sh: Language not supported
• test/code-server/code-server-disable-multiple-options.sh: Language not supported
• test/code-server/code-server-disable-proxy.sh: Language not supported
• test/code-server/code-server-disable-telemetry.sh: Language not supported
• test/code-server/code-server-disable-update-check.sh: Language not supported
• test/code-server/code-server-disable-workspace-trust.sh: Language not supported
• test/code-server/scenarios.json: Language not supported

[mafredri]

Small suggestion but otherwise LGTM.

[mafredri]

Haha, couldn't they have _'d these? 😅

[mafredri]

Suggestions: using arrays would be slightly cleaner.

args=()
args+=(--disable-file-downloads)
args+=(--disable-file-uploads)

# ...

cmd "${args[*]}"

(Note the use of * vs @ due to how we're creating the entry point, so this does not make it shell-safe when there are spaces in any inputs.)

[mafredri]

Actually, a way to make it shell safe would be:

cat > /usr/local/bin/code-server-entrypoint <<EOF
$(declare -p args)
cmd "\${args[@]}"
EOF

😄

[DanielleMaywood]

If we do that second approach do we lose the ability to test the entrypoint for containing certain flags?

[mafredri]

Both approaches I outlined should be fine for the test. But in the latter you can't test coder-server.*--flag, but you can test "--flag" individually.

[DanielleMaywood]

Ah I understand the second approach more now, I'm happy to do that one 👍