Repository navigation
fix: build with Xcode 27 - #277
Merged
Merged
Conversation
ethanndickson
force-pushed
the
fix/xcode-27
branch
from
October 29, 2026 06:19
bc2d535 to
084d422
Compare
ethanndickson
force-pushed
the
fix/xcode-27
branch
from
October 30, 2026 01:33
084d422 to
27a0095
Compare
ethanndickson
force-pushed
the
fix/xcode-27
branch
from
October 30, 2026 01:50
27a0095 to
084d422
Compare
ethanndickson
force-pushed
the
fix/xcode-27
branch
2 times, most recently
from
October 30, 2026 02:06
e561dee to
ff38e67
Compare
ethanndickson
force-pushed
the
fix/xcode-27
branch
2 times, most recently
from
November 2, 2026 08:13
219bc68 to
987a1db
Compare
Member
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ethanndickson
marked this pull request as ready for review
November 9, 2026 05:41
jakehwll
approved these changes
Nov 9, 2026
Xcode warns "No App Category is set for target 'Coder Desktop'" on every build. Set LSApplicationCategoryType through the generated Info.plist, the same way we set LSUIElement.
ethanndickson
force-pushed
the
fix/xcode-27
branch
from
November 9, 2026 05:47
987a1db to
f37d32f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm only doing this because I can't test the damn changes in #275 otherwise. I'm on Xcode 27 locally, and the app doesn't compile with it:
ButtonRowViewhad@ViewBuilderon a stored closure property, which we also assigned from a custominit, and the newer compiler rejects that. The fix is just to move@ViewBuilderonto theinitparameter and store the built view instead of the closure, which is how SwiftUI's own containers do it. I also set the initial@StatewithState(initialValue:)rather than assigning to the wrapped value.The rest is small cleanups from building with Xcode 27, i.e. dropping redundant
Sendableconformances on internal types (they're inferred), andfilter { ... }.counttocount(where:).CI still pins Xcode 26.5, so it never hit this. I haven't built this on 26.5 locally, but CI will.