feat: install and activate the tunnel provider as network extension #20
+376
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spikecurtis
force-pushed
the
spike/network-extension-install
branch
2 times, most recently
from
3b95b81 to
1683ca6
Compare
|
Rebasing... |
ethanndickson
force-pushed
the
spike/network-extension-install
branch
from
1683ca6 to
9e0b05b
Compare
|
Merging so Colin can just work off main |
ethanndickson
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With apologies, I'm sort of punting on this one for the time being.
The code works to install and allow activation of the Network Extension, but for some reason the delegate I've created to get updates about the System Extension installation is not getting called back.
I've posted on the Apple Developer Forums about it: https://forums.developer.apple.com/forums/thread/772236
In the meantime, I'm hoping to get some feedback about the code and overall design. I'll leave it in draft for now.