Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Craft 5 compatibility #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomdavies
Copy link

The field type works great with Craft 5 without any changes other than to expand the supported version of Craft in composer.json

@Havnevik
Copy link

Hi, Any update here?

@tomdavies: I am not too experienced with backend stuff, but is there a way to manually update the plugin?
I tried to copy/paste your composer.json/.lock files, but composer keeps giving me:

Problem 1
- Root composer.json requires codemonauts/craft-customizable-radio-buttons-field 2.0.0 -> satisfiable by codemonauts/craft-customizable-radio-buttons-field[2.0.0].
- codemonauts/craft-customizable-radio-buttons-field 2.0.0 requires craftcms/cms ^4.0.0-alpha -> found craftcms/cms[4.0.0-alpha.1, ..., 4.x-dev] but it conflicts with your root composer.json require (^5.0.0).

@tomdavies
Copy link
Author

@Havnevik I am not the author of this plugin (just a user like you who needed Craft 5 compatibility), but you should be able to use my branch pending this PR getting merged (though seems unlikely that will happen any time soon)

To do that do something like this in your composer.json:

  1. Add a repositories key pointing at the PR branch/repo
"repositories": [
  {
    "type": "vcs",
    "url": "https://github.com/zaengle/craft-customizable-radio-buttons-field.git"
  }
],
  1. Change the require line to dev-craft-5
"codemonauts/craft-customizable-radio-buttons-field": "dev-craft-5",

then run

composer update codemonauts/craft-customizable-radio-buttons-field

You might want to use your own clone of the repo just in case the Zaengle one goes away, though we have no plans to remove it

@Havnevik
Copy link

@Havnevik I am not the author of this plugin (just a user like you who needed Craft 5 compatibility), but you should be able to use my branch pending this PR getting merged (though seems unlikely that will happen any time soon)

To do that do something like this in your composer.json:

  1. Add a repositories key pointing at the PR branch/repo
"repositories": [
  {
    "type": "vcs",
    "url": "https://github.com/zaengle/craft-customizable-radio-buttons-field.git"
  }
],
  1. Change the require line to dev-craft-5
"codemonauts/craft-customizable-radio-buttons-field": "dev-craft-5",

then run

composer update codemonauts/craft-customizable-radio-buttons-field

You might want to use your own clone of the repo just in case the Zaengle one goes away, though we have no plans to remove it

Hi, thank you for replying :) I tried as you described, but this time I got this error:
Problem 1
- Root composer.json requires codemonauts/craft-customizable-radio-buttons-field dev-craft-5, found codemonauts/craft-customizable-radio-buttons-field[dev-dependabot/composer/craftcms/cms-4.7.0, dev-master, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 2.0.0] but it does not match the constraint.

@tomdavies
Copy link
Author

I don't think you added the repository correctly. Sorry, but I'm not going to be able to help you further here, as this is not my plugin. Google for "install composer package from github" and you should be able to figure it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants